Skip to content

Fix outstanding encountered clang-tidy misc-const-correctness - #11314

Merged
oleksandr-pavlyk merged 3 commits into
NVIDIA:mainfrom
oleksandr-pavlyk:fix-misc-const-clang-tidy-errors-encountered-in-10898
Sep 10, 2026
Merged

oleksandr-pavlyk merged 3 commits into
NVIDIA:mainfrom
oleksandr-pavlyk:fix-misc-const-clang-tidy-errors-encountered-in-10898

Conversation

@oleksandr-pavlyk

Copy link
Copy Markdown
Contributor

Nothing systematic here, but fix errors encounted outside of changeset of my PR in #10898

Description

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Nothing systematic here, but fix errors encounted outside of
changeset of my PR in NVIDIA#10898
@oleksandr-pavlyk
oleksandr-pavlyk requested review from a team as code owners September 9, 2026 20:58
@github-project-automation github-project-automation Bot moved this to Todo in CCCL Sep 9, 2026
@oleksandr-pavlyk
oleksandr-pavlyk removed the request for review from Jacobfaib September 9, 2026 20:58
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d42e8bdc-7936-40e0-9d55-2215c4b874e1

📥 Commits

Reviewing files that changed from the base of the PR and between f794a66 and 3995730.

📒 Files selected for processing (1)
  • cub/test/catch2_test_device_for_api.cu

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Improved consistency in CUDA extent handling and environment-based stream-routing tests.
    • Clarified test setup by marking local values and stream instances as immutable.
    • Updated asynchronous buffer allocation replacement tests for consistent stream handling.
  • Refactor
    • Improved const-correctness in integer parsing and related test code.
    • Parsing behavior and sign/range handling remain unchanged.

Walkthrough

The changes add const qualification to unchanged CUDA test locals and to the signed-integer from_chars minus-sign flag.

Changes

Const qualification updates

Layer / File(s) Summary
Immutable test values
cub/test/catch2_test_device_for_api.cu, cub/test/catch2_test_device_for_env.cu, libcudacxx/test/libcudacxx/cuda/containers/uninitialized_async_buffer.cu
Extents objects and stream locals use const declarations.
Immutable parsing flag
libcudacxx/include/cuda/std/__charconv/from_chars.h
Signed-integer parsing stores leading-minus detection in a const bool. Parsing and range handling remain unchanged.

Suggested reviewers: jacobfaib

Merge Risk: ⚪ Minimal · up to 39957

This change makes test locals and signed-integer sign detection immutable without altering parsing or test behavior. No current merge-blocking risk is identified.


Comment @coderabbitai help to get the list of available commands.

@oleksandr-pavlyk
oleksandr-pavlyk enabled auto-merge (squash) September 9, 2026 21:10
@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 2h 29m: Pass: 100%/297 | Total: 1d 20h | Max: 48m 59s | Hits: 99%/565319

See results here.

@oleksandr-pavlyk
oleksandr-pavlyk merged commit 5871e3d into NVIDIA:main Sep 10, 2026
325 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL Sep 10, 2026
kaatish pushed a commit to kaatish/cccl that referenced this pull request Sep 11, 2026
…#11314)

* Fix outstanding encountered clang-tidy misc-const-correctness

Nothing systematic here, but fix errors encounted outside of
changeset of my PR in NVIDIA#10898

* Fix one more issue

https://github.com/NVIDIA/cccl/actions/runs/34384989863/job/102579044195?pr=10898
charan-003 pushed a commit to charan-003/cccl that referenced this pull request Sep 15, 2026
…#11314)

* Fix outstanding encountered clang-tidy misc-const-correctness

Nothing systematic here, but fix errors encounted outside of
changeset of my PR in NVIDIA#10898

* Fix one more issue

https://github.com/NVIDIA/cccl/actions/runs/34384989863/job/102579044195?pr=10898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants